BB-543: Enable native html form functionality #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously defined in SubmissionSection
We cannot have nested html forms, that breaks native functionality
Which is to reload the page…
MonkeyDo
added a commit
that referenced
this pull request
Jun 14, 2021
Regression from PR #606 where we changed the HTML form functionality and the submission in the entity editor, but I forgot to change it in the merge editor as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in BB-543, pressing enter in a field in the entity editor page does not submit the page as a user should expect.
We were not using a properly formatted form in the entity editor, which was breaking default browser functionality.
One issue was the lack of a parent
<form>element with anonSubmitproperty, and making our submit button oftype="submit".The other issue was multiple nested form elements, which is not supported like that in HTML.
This PR fixes the form structure and re-enables default browser behavior.