Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BB-454: Should not be able to create relationship with itself #619

Merged
merged 2 commits into from
May 21, 2021
Merged

BB-454: Should not be able to create relationship with itself #619

merged 2 commits into from
May 21, 2021

Conversation

akashgp09
Copy link
Contributor

@akashgp09 akashgp09 commented May 4, 2021 •
edited
Loading

Problem

This PR Fixes: BB-454

Solution

Filtered the search field options using entity bbid

Before

Screenshot from 2021-05-04 16-13-20

After

Screenshot from 2021-05-04 15-56-01

Areas of Impact

@akashgp09
fix(relationship): Should not be able to create relationship with itself
3950083 
Signed-off-by: Akash Gupta <akashgp9@gmail.com>
@akashgp09
fix(relationship): check if bbid exist
6994e47 
Signed-off-by: Akash Gupta <akashgp9@gmail.com>
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 60.893% when pulling 6994e47 on akashgp09:search-relationships into 124ef7b on bookbrainz:master.

MonkeyDo
MonkeyDo approved these changes May 21, 2021
View reviewed changes
Copy link
Contributor

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Good fix, thanks !

@MonkeyDo MonkeyDo merged commit c6a8f0c into metabrainz:master May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MonkeyDo MonkeyDo MonkeyDo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@akashgp09 @coveralls @MonkeyDo