Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(revision): show type changes in revision page #660

Merged
merged 4 commits into from
Jul 15, 2021
Merged

fix(revision): show type changes in revision page #660

merged 4 commits into from
Jul 15, 2021

Conversation

akashgp09
Copy link
Contributor

@akashgp09 akashgp09 commented Jul 2, 2021 •
edited

Problem

Revisions for workType, authorType, publisherType, editionGroupType, editionFormat and editionStatus are not shown in the revision page.

Solution

  • Fixed some incorrect path name.
  • Modified formatChange function and conditional statement.

Screenshot:

1

New

Before

Screenshot from 2021-07-02 11-51-59

After

Screenshot from 2021-07-02 11-49-39

2

Edited

Before

Screenshot from 2021-07-02 11-52-07

After

Screenshot from 2021-07-02 11-57-00

Areas of Impact

@coveralls
Copy link

coveralls commented Jul 2, 2021 •
edited

Coverage Status

Coverage decreased (-0.04%) to 60.84% when pulling a510820 on akashgp09:fix-revision into a837286 on bookbrainz:master.

@akashgp09
improve: show type change in revision when edited
b4cf9ee 
when type value is edited revision for it isn't shown. Modified the conditional accordingly to include this case
@akashgp09
improve(revision): updated formatChange callback
9770453
MonkeyDo
MonkeyDo requested changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, and thanks for fixing that !

src/server/helpers/diffFormatters/base.js Outdated Show resolved Hide resolved
src/server/routes/revision.js Show resolved Hide resolved
MonkeyDo
MonkeyDo approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go !

@MonkeyDo MonkeyDo merged commit c7421f4 into metabrainz:master Jul 15, 2021
@akashgp09 akashgp09 mentioned this pull request Jul 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MonkeyDo MonkeyDo MonkeyDo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@akashgp09 @coveralls @MonkeyDo