FIX: Sorting does not work when there are many items #693
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Sorting isn't working as expected and undesirable results are observed when there are more than 8 items in the series.
Cause:
When an object is saved to the redux store in this order:
{ n3: { ... }, n2: { ... }, n1: { ... } }
and when retrieved back, it is returned in a sorted form by default{ n1 { ... }, n2: { ... }, n3: { ... } }
Additionally, position value is unnecessarily updated inside handleNumberAttributeChange event handler, which leads to inappropriate results in the case of manual ordering type.
Solution