Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix[BB-458]: Showing error conflict page on deleting entity twice #718

Merged
merged 5 commits into from
Dec 1, 2021

Conversation

tr1ten
Copy link
Collaborator

@tr1ten tr1ten commented Nov 26, 2021

Problem

fixing BB-458 bug

Solution

show error conflict page when user tries to delete same entity twice.

Areas of Impact

  1. src/server/routes/entity/author.js
  2. src/server/routes/entity/edition-group.js
  3. src/server/routes/entity/edition.js
  4. src/server/routes/entity/publisher.js
  5. src/server/routes/entity/series.js
  6. src/server/routes/entity/work.js

image

@welcome
Copy link

welcome bot commented Nov 26, 2021

Thanks for opening your first pull request for BookBrainz, and welcome to our community! 🎉

If you haven't yet, please check out our contributing guidelines.

Someone will be reviewing your PR soon; just hang in there !
In the meantime, if you're wondering what to do next, you can have a look at our issue tracker

Copy link
Contributor

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great, now it's a bit safer and we can't double-delete entities.

Thanks for your efforts !
In comparison to the other PRs, this one was a bit more involved and I think you did absolutely great finding your way through this complicated codebase !
Well done 🎉

@MonkeyDo MonkeyDo merged commit 3af54a8 into metabrainz:master Dec 1, 2021
@tr1ten tr1ten deleted the fix#BB-458 branch January 27, 2022 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants