Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix[BB-604]: making datepicker and link button responisve on small screen devices. #731

Merged
merged 2 commits into from
Jan 25, 2022

Conversation

tr1ten
Copy link
Collaborator

@tr1ten tr1ten commented Dec 2, 2021

Problem

BB-604: The date picker popper is hidden on small screen devices
( i also notice overflow issue with link button so fixed it as well )

Solution

add some css to fix the responsive problem

Areas of Impact

  1. src/client/stylesheets/style.less
  2. src/client/entity-editor/common/new-date-field.js
  3. src/client/entity-editor/button-bar/button-bar.js

Copy link
Contributor

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks a lot !
Fixes are working fine.

src/client/stylesheets/style.less Outdated Show resolved Hide resolved
src/client/entity-editor/common/new-date-field.js Outdated Show resolved Hide resolved
Comment on lines +186 to +187
popperModifiers={
{preventOverflow: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find ! ⭐

Copy link
Contributor

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank a lot for these fixes !

@MonkeyDo MonkeyDo merged commit 674c6bc into metabrainz:master Jan 25, 2022
@tr1ten tr1ten deleted the fix#BB-604 branch January 27, 2022 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants