Prepare client components for bootstrap 4 #764
Conversation
Other than profile.js, no other components were using ValidationState, and the FormGroup attribute supporting this is removed in the next react-bootstrap version.
bsSize, hasFeedback, name, standalone and validationState
When clicked, <a> font weight is 700, but in bs4, <small> gives a 400 font weight. So <small> must wrap <a> to avoid <a> font weight being overridden.
This ensures that the padding below the contact us buttons is consistent between desktop and mobile devices.
| @@ -112,12 +111,7 @@ const clientConfig = { | |||
| new MiniCssExtractPlugin({ | |||
| filename: 'stylesheets/[name].css' | |||
| }), | |||
| new CleanWebpackPlugin(cleanWebpackPluginOpts), | |||
| new ESLintPlugin({ | |||
There was a problem hiding this comment.
Is the goal of the removal of ESLint to make Webpack run faster?
I'm currently working on the automated Github actions we have that can annotate and even auto-fix lint issues. There are some issues with forked repos as visible here
There are some issues when it comes to PRs made from a fork repo, and we won't be able to automatically commit fixes in those PRs. Instead we are able to add annotations to the PR.
However for PR from this repo and when we merge any PR we are able to commit auto-fixed lint issues, so in combination with annotations on the PR that might be sufficient.
There was a problem hiding this comment.
We should probably remove the eslint-webpack-plugin package if we're not using it here anymore.
I could see a scenario where we would want to lint and autofix during production builds, so the plugin might be useful after all.
Review time estimate: 20 minutes
Problem
There are a number of issues which it's helpful to resolve before moving the site from Bootstrap 3 to Bootstrap 4.
Solution
Before submitting the PR that moves to BS4, this PR addresses these issues, fixing a few UI bugs, speeding up webpack compilation time and cleaning up unused code.
Areas of Impact
Client components and webpack configuration. Excluding whitespace changes, the largest diffs are to src/client/components/forms/userCollection.js and src/client/components/pages/licensing.js.