Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(BB-644): Auto append new isbn identifier row #785

Merged
merged 6 commits into from
Mar 15, 2022
Merged

Fix(BB-644): Auto append new isbn identifier row #785

merged 6 commits into from
Mar 15, 2022

Conversation

tr1ten
Copy link
Collaborator

@tr1ten tr1ten commented Feb 25, 2022

Problem

BB-644: Automatically generate ISBN-13 from ISBN-10 and vice versa

Solution

append new identifier row on adding any isbn

Areas of Impact

common utils, identifier row component

MonkeyDo
MonkeyDo reviewed Mar 2, 2022
View reviewed changes
Copy link
Contributor

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane at a quick glance.

I'd love to see unit tests for the conversion methods, and throwing all the valid and invalid ISBN formats we can think of

MonkeyDo
MonkeyDo approved these changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks !

@MonkeyDo MonkeyDo merged commit c6a9860 into metabrainz:master Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MonkeyDo MonkeyDo MonkeyDo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@tr1ten @MonkeyDo