Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bs4): Make exactMatches ListGroupItems links #791

Merged
merged 1 commit into from
Mar 3, 2022

Conversation

MonkeyDo
Copy link
Contributor

@MonkeyDo MonkeyDo commented Mar 3, 2022

Problem

As reported in the forums the possible duplicate entities are not clickable anymore.
image

introduced in the Bootstrap v4 migration: 30518ca

Solution

Simply adding the action boolean prop turns the list group item into an anchor tag.
From react-bootstrap docs:

Toggle the action prop to create actionable list group items, with disabled, hover and active styles. List item actions will render a or (depending on the presence of an href) by default

This component is the only ListGroup.Item that has an href and that we use as a link.

Areas of Impact

src/client/entity-editor/name-section/name-section.js

The action prop is used to make ListGroup.Item components into anchors (when used in combination with href)
Copy link
Member

@LordSputnik LordSputnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple - looks good to me!

@LordSputnik LordSputnik merged commit 0358100 into master Mar 3, 2022
@LordSputnik LordSputnik deleted the monkey-fix-listgroup-item branch March 3, 2022 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants