Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Collection): conditionally render author name column in the Work Table component #793

Merged
merged 5 commits into from
Mar 4, 2022

Conversation

the-good-boy
Copy link
Contributor

@the-good-boy the-good-boy commented Mar 4, 2022

Problem

If authorsData is undefined (in case of collections, it will be undefined), the author name column should not be rendered.

Solution

check if authorData is defined before trying to render it in the WorkTableRow component

Copy link
Contributor

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quickfix !

As discussed we're gonna want to think about how to refactor the existing code to show authors on collection pages workTables (for work collections), but now we can take our time :)

@MonkeyDo MonkeyDo merged commit b919b95 into metabrainz:master Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants