MEB-135: Standardizing MetaBrainz Logos #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MonkeyDo
reviewed
Apr 15, 2022
There was a problem hiding this comment.
It looks like BookBrainz_logo_short_vertical.svg and BookBrainz_logo_small_short_vertical.svg are the same as before.
We don't use any of the vertical logos or any of the logo_small versions anywhere on the website, so we could possibly even delete the files.
No reason to keep copies here if they're not used and will need to be maintained (like we're doing now)
Apart from that everything looks good, thank you !
|
Thanks Monkey! Ah yes, I the vertical stack logos didn't get any changes, indeed. |
MonkeyDo
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating logos to current version: Taller caps, Roboto Black font