Feat(Achievement): Show achievement progress #844
Conversation
There was a problem hiding this comment.
I get an error when I run this PR locally and try to open my achievements page:
error: select "bookbrainz"."_editor_entity_visits".* from "bookbrainz"."_editor_entity_visits" where "editor_id" = $1 - relation "bookbrainz._editor_entity_visits" does not exist
The table does exist in production, but not in the database dumps I guess, which includes the one used on test.bookbrainz.org
How did you test it locally?
I thought so this would be the case here thus i created one for testing purposes |
| return getEditsInDays(orm, editorId, 6); | ||
| } | ||
| if (achievementId === 12) { | ||
| return getEditsInDays(orm, editorId, 29); |
There was a problem hiding this comment.
Testing locally, I can see this achievement doesn't work as expected.
It counts days where I made a revision, but not consecutive days.
So for example if I made a revision on the 1st, 2nd and 3rd of the month, then nothing for a few days, then another revision on the 6th, the progress should be 0.
Instead, currently it is going to return 4.
I suspect the same goes for "Fun Runner" (achievement # 10).
This doesn't need to be fixed in this PR, since it does not result from these changes, I will create a ticket for it.
There was a problem hiding this comment.
| {!this.state.unlocked && | ||
| <Col> | ||
| <div className="h3"> | ||
| {this.state.counter}/{maxAchievementProgress[this.state.achievement.id] ?? 0} |
There was a problem hiding this comment.
How about adding a progress bar in here?
We can show the percentage as a label in the progress bar, and center all of it.:
https://react-bootstrap-v4.netlify.app/components/progress/#progress-label
Something along those lines; what do you think?
There was a problem hiding this comment.
Progress bar does seem like a good idea, how about a circular one (eg), placing text at its center?
There was a problem hiding this comment.
I think that's an interesting idea, and would look quite good.
However I would suggest doing so in a separate PR later on, as it seems to me the whole page needs many visual improvements. I don't want to sidetrack you from your GSoC project.
It'll be a good improvement to go with the rest, and in the meantime we avoid adding another dependency when we already have a progress component in react-bootstrap.
Problem
BB-505: Show achievement progress
Areas of Impact
achievement, editor