Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(EntityEditor): Optimize Entity Editor's components #845

Merged
merged 3 commits into from
May 31, 2022
Merged

Fix(EntityEditor): Optimize Entity Editor's components #845

merged 3 commits into from
May 31, 2022

Conversation

tr1ten
Copy link
Collaborator

@tr1ten tr1ten commented May 23, 2022

Problem

Slow behavior of entity editor form

Solution

minimize the re-render cycle for different components of entity editor

@tr1ten tr1ten marked this pull request as ready for review May 30, 2022 15:19
MonkeyDo
MonkeyDo approved these changes May 31, 2022
View reviewed changes
Copy link
Contributor

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome improvement, and super clean in the end !

We should keep that in mind if we ever encounter another state update bottleneck!

@MonkeyDo MonkeyDo merged commit d72e08a into metabrainz:master May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MonkeyDo MonkeyDo MonkeyDo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@tr1ten @MonkeyDo