chore: Docker setup improvements #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MonkeyDo
commented
May 25, 2022
MonkeyDo
commented
- Follow guidelines for docker-compose file
- Simplify database creation (use postgres image env variables instead of running a script)
- Make the database init script a bit more reusable
Only bind ports to local ip address to avoid this docker-compose file leading to open ports if used as-is in a dev environment
Instead of having to run a separate script we can just use the postgres docker image env variables to create the DB and user on first start. Thanks alastairp !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.