Fix(AC): users should be able to make Author Credits optional #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MonkeyDo
changed the title
MonkeyDo
reviewed
Sep 1, 2022
src/client/entity-editor/author-credit-editor/author-credit-section.tsx
Outdated
Show resolved
Hide resolved
MonkeyDo
reviewed
Sep 8, 2022
There was a problem hiding this comment.
This is looking pretty good
I tried the PR locally, but it looks like creation an Edition with name section filled, EG selected and AC disabled is not considered valid (submit button is disabled).
Can you please also try this?
Secondly, we should disable the AC edit button when AC is disabled. Currently with AC disabled the AC field is disabled but I can still click edit to open the modal.
Previously it was in the buttonBar section, which is eventually going to be deprecated.
to author-credit-editor actions file, so that it can be shared between the Edition and EditionGroup sections
Reworked mapStateToProps and the new checkbox to disable ACs to fix a couple of issues and simplify a tad
Went from buttonBar to editionSection / editionGroupSection
For new entities whose entitySection is an empty object
which might be undefined (for new entities) in mapStateToProps
Made a mistake when refactoring !
missing `authorCreditEnable: false` for all the edition data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things: