Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BB-662 (II): Links don't open in new tab #927

Merged
merged 1 commit into from
Feb 27, 2023
Merged

BB-662 (II): Links don't open in new tab #927

merged 1 commit into from
Feb 27, 2023

Conversation

Shelly011s
Copy link
Contributor

@Shelly011s Shelly011s commented Feb 1, 2023 •
edited
Loading

Problem

Its an extension of the ticket https://tickets.metabrainz.org/browse/BB-662

Solution

I fixed the the link so that it opens in new tab.

Areas of Impact

utils.tsx in helpers

@Shelly011s Shelly011s changed the title BB-662 - URLs are turned into malformed links Links don't open in new tab Feb 1, 2023
@MonkeyDo MonkeyDo changed the title Links don't open in new tab BB-662 (II): Links don't open in new tab Feb 27, 2023
MonkeyDo
MonkeyDo approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, a simple improvement but a good quality of life one :)

@MonkeyDo MonkeyDo merged commit 7403a71 into metabrainz:master Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MonkeyDo MonkeyDo MonkeyDo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Shelly011s @MonkeyDo