BB-707: Don't create CBReviewModal for deleted entities #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't load a deleted entity page, the website just times out and returns a 504.
Looking at the logs, we see:
Looking at the WorkDisplayPage component, the issue is pretty clear: we are trying to pass
entity.defaultAlias.nameas a prop to the CBReviewModal, but on a deleted entity defaultAlias will be undefined, resulting in the error above.The same goes for the other reviewable entities.
Solution: wrap the modal in the same condition we use elsewhere in the same pages:
{!entity.deleted && <CBReviewModal …There might be another issue described in the ticket, but at least the 504 issue is solved in this PR.