Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BB-692: Add test for checkValidRevisionID #963

Merged
merged 5 commits into from Mar 20, 2023
Merged

BB-692: Add test for checkValidRevisionID #963

merged 5 commits into from Mar 20, 2023

Conversation

the-good-boy
Copy link
Contributor

Problem

This PR is a continuation of this PR and adds a test for the same.

@MonkeyDo MonkeyDo changed the title test(BB-692): Add test for checkValidRevisionID BB-692: Add test for checkValidRevisionID Mar 14, 2023
MonkeyDo
MonkeyDo reviewed Mar 16, 2023
View reviewed changes
Copy link
Contributor

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding tests !
Small bits of feedback around the test file itself, but apart from that the tests look great.

test/src/server/routes/revision.js Outdated Show resolved Hide resolved
test/src/server/routes/revision.js Show resolved Hide resolved
test/src/server/routes/revision.js Show resolved Hide resolved
MonkeyDo
MonkeyDo approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last little bit, and good to go, thank you :)

test/src/server/routes/revision.js Outdated Show resolved Hide resolved
@MonkeyDo MonkeyDo merged commit 672e6e9 into metabrainz:master Mar 20, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MonkeyDo MonkeyDo MonkeyDo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@the-good-boy @MonkeyDo