Fix docker #1
Open
Fix docker #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't work as of yet as some parts of the included irc library appear to be broken in recent Go versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated the Dockerfile to use a multi-stage build and a pinned version of the Go base image.
Unfortunately some code in the included IRC library seems to be broken in recent versions of Go. For reference, the current instance of the bot running for chatlogs.meb.org still uses Go 1.2 for which I couldn't find docker images.The bot seems to run fine on Go 1.10.
Ideally the IRC library should probably be replaced with a more stable external dependency.
During testing with InspIRCd the bot tried to join channels before being authenticated so further testing is probably still required.