Merge pull request #159 from ps2611/cb-268/new-revision

CB-268: Update review only if contents are edited

critiquebrainz/frontend/views/review.py

@@ -275,7 +275,10 @@ def edit(id):
         # Can't change license if review is published.
         del form.license_choice
 
-    if form.validate_on_submit():
+    # Check if contents of the review are updated
+    if form.text.data == review['text'] and form.rating.data == review['rating']:
+        form.errors['edit'] = ["You must edit either text or rating to update the review."]
+    elif form.validate_on_submit():
         if review["is_draft"]:
             license_choice = form.license_choice.data
         else:

critiquebrainz/frontend/views/test/test_review.py

@@ -117,6 +117,12 @@ def test_edit(self):
         self.assert200(response)
         self.assertIn(updated_text, str(response.data))
 
+        # edit once again with the same test and check for error
+        response = self.client.post('/review/%s/edit' % review['id'], data=data,
+                                    query_string=data, follow_redirects=True)
+        self.assert200(response)
+        self.assertIn('You must edit either text or rating to update the review.', str(response.data))
+
     def test_delete(self):
         review = self.create_dummy_review()