CB-321: No empty comments #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bimalkant-lauhny
force-pushed
the
no-empty-comments
branch
2 times, most recently
from
f82fe12
to
66bf771
Compare
bimalkant-lauhny
force-pushed
the
no-empty-comments
branch
from
66bf771
to
9249b8d
Compare
bimalkant-lauhny
force-pushed
the
no-empty-comments
branch
from
4b74a73
to
5863be1
Compare
|
@paramsingh Please review this. |
paramsingh
approved these changes
Oct 31, 2018
paramsingh
reviewed
Nov 12, 2018
| @@ -0,0 +1,8 @@ | |||
| BEGIN; | |||
|
|
|||
| ALTER TABLE "comment_revision" | |||
There was a problem hiding this comment.
Generally, we'd have to think about what we want to do with empty comments already in the db before we add a constraint, but I checked and there aren't any empty comments (or any comments whatsoever) in the db so we should be okay.
paramsingh
requested changes
Nov 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed SQL and Comment Form to reject empty comments.