Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests for unknown_entities_for_missing=True fix #322

Merged
merged 1 commit into from Dec 3, 2020

Conversation

alastair
Copy link
Collaborator

@alastair alastair commented Dec 2, 2020

In 47a6164 (#304) we added unknown_entities_for_missing=True to calls to the BU musicbrainz db methods, but for some reason forgot to update the tests.
Also missing was this flag on Label, add it.

Copy link
Member

@amCap1712 amCap1712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for the fix!

@alastair alastair merged commit 13e6da3 into master Dec 3, 2020
@alastair alastair deleted the unknown-entities-cache branch February 11, 2021 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants