Always return dummy data in debug mode if it's not in MusicBrainz #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is so that we can see reviews during development when using the musicbrainz sample database
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is so that we can see reviews during development when using the musicbrainz sample database. By default, if the entity being reviewed isn't in the musicbrainz database, it is omitted from the list, but with a sample database this means that only 3 or 4 reviews are ever shown, even on a full CB data dump.
When DEBUG=True, any time that a review is shown in a list or on a review page, and no related entity is in the connected musicbrainz database, a dummy title/artist will be shown.
Going to the entity page on the local CB server will still raise a 404, this change only affects reviews.