Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queries to be used in dropdown for similar results #14

Merged
merged 1 commit into from Aug 10, 2023

Conversation

VishalFTW
Copy link
Contributor

This branch contains commits from pydantic support PR, since the PR was not merged and these changes follow it, I had to create this conflicting PR.

Description about the changes -
Changes will allow to have a dropdown to the right of each of the artist_mbids, the dropdown should have one item for each type of query on the dataset hoster that accepts artist_mbid as an argument. If the user selects that item a new browser tab opens and that query is run. If there is another argument like algorithm which was also present in the current query use the same value to start the new query. Thus, allowing to see the similar results.

More details can be found over here.

Copy link
Member

@amCap1712 amCap1712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it locally and it seems to work fine. Great Work. Thanks!

@amCap1712 amCap1712 merged commit bca7527 into metabrainz:master Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants