Skip to content
This repository has been archived by the owner on Jan 25, 2022. It is now read-only.

Commit

Permalink
PEP8 fixups for discogs scripts.
Browse files Browse the repository at this point in the history
  • Loading branch information
@ianmcorvidae
ianmcorvidae committed Mar 1, 2013
1 parent dda85c7 commit e055cf5
Show file tree
Hide file tree
Showing 2 changed files with 188 additions and 188 deletions.
148 changes: 74 additions & 74 deletions tools/discogs/discogs_parser.py
View file
Expand Up @@ -7,83 +7,83 @@
from xml.sax.saxutils import escape, quoteattr

class DiscogsHandler(xml.sax.handler.ContentHandler):
def __init__(self, entity):
self.tree = []
self.string = ""
self.id = ""
self.name = ""
self.entity = entity
self.count = 0
self.content = ""

def startElement(self, name, attrs):
self.tree.append(name)

# Ignore the top-level container, e.g. <releases>
if len(self.tree) == 1:
return

# Create the opening tag and its attributes
self.string += "<" + name
for attr in attrs.getNames():
self.string += " " + attr + "=" + quoteattr(attrs.getValue(attr))
self.string += ">"

# IDs for masters are an attribute of the <master> element
if len(self.tree) == 2 and attrs.has_key("id") and name == "master":
self.id = attrs.getValue("id")

def endElement(self, name):
self.tree.pop()

# Create the closing tag
self.string += escape(self.content) + "</" + name + ">"
self.content = ""

if len(self.tree) == 1 and name == self.entity:
if self.entity == "label" and self.name != "":
filename = "labels/" + hashlib.md5(self.name.encode("utf-8")).hexdigest()
f = open(filename, "w")
f.write(self.string.encode("utf-8"))
f.close()
elif self.id != "":
filename = self.entity + "s/" + self.id
f = open(filename, "w")
f.write(self.string.encode("utf-8"))
f.close()
else:
print "No ID found D:"
print self.string.encode("utf-8")

# Reset variables
self.string = ""
self.id = ""
self.name = ""

# self.count = self.count + 1
# if (self.count > 10000):
# # FIXME: There must be a more appropriate exception to raise.
# raise NameError("Reached maximum number of entries.")

def characters(self, content):
self.content += content

# IDs for artists and labels are a sub-element of <artist> and <label>
if len(self.tree) == 3 and self.tree[2] == "id" and self.tree[1] == "artist":
self.id += content
if len(self.tree) == 3 and self.tree[2] == "name" and self.tree[1] == "label":
self.name += content
def __init__(self, entity):
self.tree = []
self.string = ""
self.id = ""
self.name = ""
self.entity = entity
self.count = 0
self.content = ""

def startElement(self, name, attrs):
self.tree.append(name)

# Ignore the top-level container, e.g. <releases>
if len(self.tree) == 1:
return

# Create the opening tag and its attributes
self.string += "<" + name
for attr in attrs.getNames():
self.string += " " + attr + "=" + quoteattr(attrs.getValue(attr))
self.string += ">"

# IDs for masters are an attribute of the <master> element
if len(self.tree) == 2 and 'id' in attrs and name == "master":
self.id = attrs.getValue("id")

def endElement(self, name):
self.tree.pop()

# Create the closing tag
self.string += escape(self.content) + "</" + name + ">"
self.content = ""

if len(self.tree) == 1 and name == self.entity:
if self.entity == "label" and self.name != "":
filename = "labels/" + hashlib.md5(self.name.encode("utf-8")).hexdigest()
f = open(filename, "w")
f.write(self.string.encode("utf-8"))
f.close()
elif self.id != "":
filename = self.entity + "s/" + self.id
f = open(filename, "w")
f.write(self.string.encode("utf-8"))
f.close()
else:
print "No ID found D:"
print self.string.encode("utf-8")

# Reset variables
self.string = ""
self.id = ""
self.name = ""

# self.count = self.count + 1
# if (self.count > 10000):
# # FIXME: There must be a more appropriate exception to raise.
# raise NameError("Reached maximum number of entries.")

def characters(self, content):
self.content += content

# IDs for artists and labels are a sub-element of <artist> and <label>
if len(self.tree) == 3 and self.tree[2] == "id" and self.tree[1] == "artist":
self.id += content
if len(self.tree) == 3 and self.tree[2] == "name" and self.tree[1] == "label":
self.name += content

if not len(sys.argv) > 1:
print "The date of the filenames should be provided as an argument."
sys.exit()
print "The date of the filenames should be provided as an argument."
sys.exit()

print "Loading data for " + sys.argv[1]

for entity in ("artist", "label", "master"):
filename = "discogs_" + sys.argv[1] + "_" + entity + "s.xml"
print "Parsing " + entity + " data from " + filename
try:
xml.sax.parse(filename, DiscogsHandler(entity))
except NameError:
pass
filename = "discogs_" + sys.argv[1] + "_" + entity + "s.xml"
print "Parsing " + entity + " data from " + filename
try:
xml.sax.parse(filename, DiscogsHandler(entity))
except NameError:
pass
228 changes: 114 additions & 114 deletions tools/discogs/discogs_release_parser.py
View file
Expand Up @@ -7,126 +7,126 @@
from xml.sax.saxutils import escape, quoteattr

class DiscogsHandler(xml.sax.handler.ContentHandler):
def __init__(self):
self.tree = []
self.string = ""
self.id = ""
self.count = 0
self.artists = []
self.masters = []
self.labels = []
self.artist = ""
self.master = ""
self.content = ""

def startElement(self, name, attrs):
self.tree.append(name)

# Ignore the top-level container, e.g. <releases>
if len(self.tree) == 1:
return

# Create the opening tag and its attributes
self.string += "<" + name
for attr in attrs.getNames():
self.string += " " + attr + "=" + quoteattr(attrs.getValue(attr))
self.string += ">"

# Store release ID
if len(self.tree) == 2 and attrs.has_key("id") and name == "release":
self.id = attrs.getValue("id")

# Store label IDs
if name == "label" and attrs.has_key("name"):
self.labels.append(attrs.getValue("name"))

def endElement(self, name):
self.tree.pop()

# Create the closing tag
self.string += escape(self.content) + "</" + name + ">"
self.content = ""

# Store the final artist ID
if name == "artist" and self.artist != "":
self.artists.append(self.artist)
self.artist = ""

# Store the final master ID
if name == "master_id" and self.master != "":
self.masters.append(self.master)
self.master = ""

if len(self.tree) == 1 and name == "release":
if self.id != "":
relf = open("releases/" + self.id + ".xml", "w")
relf.write("<discogs>")
relf.write(self.string.encode("utf-8"))

for artist in set(self.artists):
filename = "artists/" + artist
try:
f = open(filename)
relf.write(f.read())
f.close()
except:
# There are some IDs for placeholders, e.g. 194 to represent Various
print "Data for artist " + artist + " not found"

for master in set(self.masters):
filename = "masters/" + master
try:
f = open(filename)
relf.write(f.read())
f.close()
except:
print "Data for master " + master + " not found"

for label in set(self.labels):
filename = "labels/" + hashlib.md5(label.encode("utf-8")).hexdigest()
try:
f = open(filename)
relf.write(f.read())
f.close()
except:
print "Data for label " + label + " not found"

relf.write("</discogs>")
relf.close()

else:
print "No ID found D:"
print self.string.encode("utf-8")

self.string = ""
self.id = ""
self.artists = []
self.masters = []
self.labels = []

# self.count = self.count + 1
# if (self.count > 10000):
# # FIXME: There must be a more appropriate exception to raise.
# raise NameError("Reached maximum number of entries.")

def characters(self, content):
self.content += content

# characters can contain partial information, so append to a string for now
if self.tree[ len(self.tree) - 1 ] == "master_id":
self.master += content
if self.tree[ len(self.tree) - 1 ] == "id" and self.tree[ len(self.tree) - 2 ] == "artist":
self.artist += content
def __init__(self):
self.tree = []
self.string = ""
self.id = ""
self.count = 0
self.artists = []
self.masters = []
self.labels = []
self.artist = ""
self.master = ""
self.content = ""

def startElement(self, name, attrs):
self.tree.append(name)

# Ignore the top-level container, e.g. <releases>
if len(self.tree) == 1:
return

# Create the opening tag and its attributes
self.string += "<" + name
for attr in attrs.getNames():
self.string += " " + attr + "=" + quoteattr(attrs.getValue(attr))
self.string += ">"

# Store release ID
if len(self.tree) == 2 and 'id' in attrs and name == "release":
self.id = attrs.getValue("id")

# Store label IDs
if name == "label" and 'name' in attrs:
self.labels.append(attrs.getValue("name"))

def endElement(self, name):
self.tree.pop()

# Create the closing tag
self.string += escape(self.content) + "</" + name + ">"
self.content = ""

# Store the final artist ID
if name == "artist" and self.artist != "":
self.artists.append(self.artist)
self.artist = ""

# Store the final master ID
if name == "master_id" and self.master != "":
self.masters.append(self.master)
self.master = ""

if len(self.tree) == 1 and name == "release":
if self.id != "":
relf = open("releases/" + self.id + ".xml", "w")
relf.write("<discogs>")
relf.write(self.string.encode("utf-8"))

for artist in set(self.artists):
filename = "artists/" + artist
try:
f = open(filename)
relf.write(f.read())
f.close()
except:
# There are some IDs for placeholders, e.g. 194 to represent Various
print "Data for artist " + artist + " not found"

for master in set(self.masters):
filename = "masters/" + master
try:
f = open(filename)
relf.write(f.read())
f.close()
except:
print "Data for master " + master + " not found"

for label in set(self.labels):
filename = "labels/" + hashlib.md5(label.encode("utf-8")).hexdigest()
try:
f = open(filename)
relf.write(f.read())
f.close()
except:
print "Data for label " + label + " not found"

relf.write("</discogs>")
relf.close()

else:
print "No ID found D:"
print self.string.encode("utf-8")

self.string = ""
self.id = ""
self.artists = []
self.masters = []
self.labels = []

# self.count = self.count + 1
# if (self.count > 10000):
# # FIXME: There must be a more appropriate exception to raise.
# raise NameError("Reached maximum number of entries.")

def characters(self, content):
self.content += content

# characters can contain partial information, so append to a string for now
if self.tree[len(self.tree) - 1] == "master_id":
self.master += content
if self.tree[len(self.tree) - 1] == "id" and self.tree[len(self.tree) - 2] == "artist":
self.artist += content

if not len(sys.argv) > 1:
print "The date of the filenames should be provided as an argument."
sys.exit()
print "The date of the filenames should be provided as an argument."
sys.exit()

print "Loading data for " + sys.argv[1]

filename = "discogs_" + sys.argv[1] + "_releases.xml"
print "Parsing release data from " + filename
try:
xml.sax.parse(filename, DiscogsHandler())
xml.sax.parse(filename, DiscogsHandler())
except NameError:
pass
pass

0 comments on commit e055cf5

Please sign in to comment.