Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesigned ListenService #137

Merged
merged 5 commits into from Apr 28, 2023
Merged

Redesigned ListenService #137

merged 5 commits into from Apr 28, 2023

Conversation

07jasjeet
Copy link
Contributor

@07jasjeet 07jasjeet commented Apr 24, 2023 •
edited

ONLY MERGE AFTER #136

Problem

  1. MOBILE-127
  2. Listen was only submitted when the previous song was paused, then played and then skipped to desired song. Listens were not submitted at all if songs were played continuously without break.

Solution

Redesign with timer to keep seconds in count and removed all the confusing code before.

akshaaatt
akshaaatt approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member

@akshaaatt akshaaatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the update 💯

app/src/main/java/org/listenbrainz/android/model/ListenSubmitBody.kt Outdated Show resolved Hide resolved
@akshaaatt akshaaatt merged commit 260e2d6 into metabrainz:main Apr 28, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshaaatt akshaaatt akshaaatt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@07jasjeet @akshaaatt