Fix: Declare NewsBrainzActivity in androidManifest #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clicking the News button in the main screen does not open the News activity as it's not defined in the AndroidManifest
|
@akshaaatt idk why but I can't seem to add you a reviewer. Tagging you :) |
akshaaatt
requested changes
May 29, 2023
app/src/main/AndroidManifest.xml
Outdated
| android:exported="false" | ||
| android:label="@string/title_activity_news_brainz" | ||
| android:theme="@style/AppTheme"> | ||
| <meta-data |
There was a problem hiding this comment.
This is not a shared library or anything so we don't need this tag here. Please remove it.
app/src/main/AndroidManifest.xml
Outdated
| @@ -38,6 +38,16 @@ | |||
| android:value="" /> | |||
| </activity> | |||
|
|
|||
| <activity | |||
| android:name=".ui.screens.newsbrainz.NewsBrainzActivity" | |||
| android:exported="false" | |||
There was a problem hiding this comment.
We don't actually need to specify this until and unless an intent filter is added to the activity.
app/src/main/AndroidManifest.xml
Outdated
| android:name=".ui.screens.newsbrainz.NewsBrainzActivity" | ||
| android:exported="false" | ||
| android:label="@string/title_activity_news_brainz" | ||
| android:theme="@style/AppTheme"> |
There was a problem hiding this comment.
The default theme for the app is this, hence even if we don't duplicate it here, it will pick the same theme.
|
@prabalsingh24 I was in a hurry to make a beta release of the app, hence pushed the fix for it. Thanks a lot for bringing this up though! 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clicking the News button in the main screen does not open the News activity as it's not defined in the AndroidManifest