Fix: don't fetch cover art urls twice #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prabalsingh24
force-pushed
the
dont-fetch-url-twice
branch
from
f87767a
to
30592f2
Compare
|
@akshaaatt this makes sense right? we're already fetching urls while fetching the listens. No need to make the API call again |
akshaaatt
approved these changes
May 29, 2023
|
This flow was used to give pre-loader URLs to work with. Since the pre loader is now removed, might as well get rid of the coverArtFlow as well and use the function as is. |
|
@07jasjeet that sounds right to me. I think removing the flow would be the better option here @prabalsingh24 since it involves storing things separately and then accessing them via index. |
|
For now, this is correct and I don't wanna burden the PR with optimizations because this fix is important. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.