Feed section phase 2.5 #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since null in max_ts means server assumes max_ts as current time, it makes sense to just leave it as null.
This reverts commit 6a49331.
1) Connection and disconnection to spotify app remote is now coroutine safe. 2) Spotify app remote connection now persists as long as the app is visible to user.
This is done to reuse the same code for API calls and not write API calls again and again for each view-model. Also, Refactored dependencies a bit.
This was done due to ill experience when in landscape mode.
1) Moved remotePlaybackHandler code to SocialViewModel for reuse. 2) LBAccessToken will be null if no value is assigned. Earlier, null was converted to empty string
1) Repository boilerplate converted to parseResponse {} function.
2) API service refactored.
3) Established helper functions to reduce boilerplate.
4) ListensViewModel and ListensScreen refactored.
1) Migrated some shared preferences to data store. 2) As a result, a lot of UI components that were dependent on shared prefs are now reactive. 3) Listens screen refactor.
1) Migrated Ui mode to datastore and removed dependency on shared preferences. 2) Polished Explore screen.
akshaaatt
reviewed
Oct 24, 2023
sharedTest/src/main/java/org/listenbrainz/sharedtest/utils/ResourceString.kt
Show resolved
Hide resolved
app/src/main/java/org/listenbrainz/android/service/ApiService.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/listenbrainz/android/ui/components/dialogs/BaseDialog.kt
Show resolved
Hide resolved
|
Also, the YearInMusicActivityTest seems to be breaking for me. Wonder why the CI didn't fail for this though. |
I think I may have changed some things here and there but I don't exactly know what errors you might be getting. |
1) Reverted dissolution of individual Services and adopted sharing of OkHttpClient client instead. 2) Fixed a bug where Listen's screen wasn't loading
akshaaatt
reviewed
Oct 26, 2023
app/src/main/java/org/listenbrainz/android/service/ApiService.kt
Outdated
Show resolved
Hide resolved
akshaaatt
reviewed
Oct 26, 2023
|
@07jasjeet can you fix the tests for this? Also, ready for review right? |
Oops didn't knew tests broke again gimme a sec. |
akshaaatt
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks