Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model cleanup and UX enhancements #18

Merged
merged 7 commits into from
Feb 23, 2024

Conversation

gauravbhardwaj7
Copy link
Contributor

Problem

Many users' feed was getting blank due to unnecessary parameters present in the feed model.

Solution

Refactored parameters in the model and used only relevant parameters that we are using in the frontend.

Other Changes

  • Fix navigation for iPad users.
  • UX enhancement in the TopBar , made similar to that of LB-android.
  • Model cleanup for Listens

Copy link
Member

@akshaaatt akshaaatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gauravbhardwaj7 just a note that we will have to uncomment those fields at some point as we use them. So this is a temporary fix currently

@gauravbhardwaj7
Copy link
Contributor Author

@gauravbhardwaj7 just a note that we will have to uncomment those fields at some point as we use them. So this is a temporary fix currently

@akshaaatt , what should be the ideal way of doing this? , imo we can go with it in the current implementation and we can uncomment parameters only when we're gonna use them in the frontend.

@akshaaatt
Copy link
Member

@gauravbhardwaj7 We usually make the model files first since we know that this is the data we have from the api and can gradually start using it. But since the api keeps changing for some reason (which shouldn't happen without us being informed), we can use on the go as you did

Copy link
Member

@akshaaatt akshaaatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine for now. Thanks!

@akshaaatt akshaaatt merged commit 9e13a46 into metabrainz:main Feb 23, 2024
@gauravbhardwaj7 gauravbhardwaj7 deleted the fix-model branch February 23, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants