-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Model cleanup and UX enhancements #18
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gauravbhardwaj7 just a note that we will have to uncomment those fields at some point as we use them. So this is a temporary fix currently
@akshaaatt , what should be the ideal way of doing this? , imo we can go with it in the current implementation and we can uncomment parameters only when we're gonna use them in the frontend. |
@gauravbhardwaj7 We usually make the model files first since we know that this is the data we have from the api and can gradually start using it. But since the api keeps changing for some reason (which shouldn't happen without us being informed), we can use on the go as you did |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine for now. Thanks!
Problem
Many users' feed was getting blank due to unnecessary parameters present in the feed model.
Solution
Refactored parameters in the model and used only relevant parameters that we are using in the frontend.
Other Changes