Integrated user-listen api #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshaaatt
requested changes
May 30, 2023
Listenbrainz/model/musicModel.swift
Outdated
| @@ -0,0 +1,135 @@ | |||
| // | |||
There was a problem hiding this comment.
Can you please make every struct a separate file in the model folder? Also, Keep the file name the same as the struct name.
akshaaatt
reviewed
May 30, 2023
Made changes in the music model and updated according to the new JSON response.
Made userName parameter in the API dynamic.
akshaaatt
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR which is having following changes-
1.) Made music model having fields of the user listen api.
2.) Fetched user listens in the listens view from the api.
Note - Please Don't consider the files APICall.swift, APIData.swift and Helper.swift , As I was experimenting things in this branch and unfortunately it also got pushed along with my main code.