In case of error 504 the API returns HTML instead of JSON #1092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @AbhinavOhri! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
paramsingh
approved these changes
Sep 17, 2020
There was a problem hiding this comment.
I'm happy to merge this, we should have these error handlers.
However, the HTML is actually returned on the gateway level, and flask code isn't even run, as such this problem can't be solved by changing code in LB, it needs gateway level changes which I guess only zas can do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In case of error 504 the API returns HTML instead of JSON
Solution
Added error handlers for the respective errors