Recommendation feedback [DB + API] #1143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @vansika! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2020-10-20 11:08:46 UTC |
mayhem
reviewed
Oct 16, 2020
listenbrainz/webserver/views/recommendations_cf_recording_feedback_api.py
Show resolved
Hide resolved
listenbrainz/webserver/views/recommendations_cf_recording_feedback_api.py
Outdated
Show resolved
Hide resolved
|
@mayhem pushed the requested changes and tests. Have a look, I want to merge it today, possibly :) |
|
I doubt I'll have time until Tuesday, sadly. |
mayhem
reviewed
Oct 17, 2020
listenbrainz/db/tests/test_recommendations_cf_recording_feedback.py
Outdated
Show resolved
Hide resolved
listenbrainz/tests/integration/test_recommendations_cf_recording_feedback_api.py
Show resolved
Hide resolved
vansika
requested review from
mayhem and
shivam-kapila
and removed request for
shivam-kapila
mayhem
approved these changes
Oct 20, 2020
listenbrainz/db/tests/test_recommendations_cf_recording_feedback.py
Outdated
Show resolved
Hide resolved
vansika
force-pushed
the
rec-feedback-db-api
branch
from
e805734
to
639210e
Compare
vansika
added a commit
to vansika/listenbrainz-server
that referenced
this pull request
Dec 24, 2020
* recommendation feedback model * use enum vals as feeeback to store in db * db and api script for recommendation feedback * PEP-8 fixes * tests feedback (db) * tests feedback (API) * tests update * don't create two objects
vansika
added a commit
to vansika/listenbrainz-server
that referenced
this pull request
Jan 17, 2021
* recommendation feedback model * use enum vals as feeeback to store in db * db and api script for recommendation feedback * PEP-8 fixes * tests feedback (db) * tests feedback (API) * tests update * don't create two objects
mayhem
pushed a commit
that referenced
this pull request
Jan 20, 2021
* schema for storing recommendation feedback (#1126) * schema for recommendation feedback * rename enum strings and enum name * Separate component for Recommendations (#1133) * recommendation componeent and recommendation card * CSS for recommendation component * shift recommendationPaginationControl to main method don't modify bootstrap classes in recommendation-page.less * fix utils.tsx error * html emoticons for rec feddback * update func name * revamp listens and recommendations type * tests for recommendation component * tests for rec component * Refactor RecentListens - Remove recommendations code (#1146) * refactor recentListens * fix indentation * remove unused const * Recommendation feedback [DB + API] (#1143) * recommendation feedback model * use enum vals as feeeback to store in db * db and api script for recommendation feedback * PEP-8 fixes * tests feedback (db) * tests feedback (API) * tests update * don't create two objects * Sync recommendation feedback with emoticons (#1149) * tests feedback (db) * tests update * sync feedback * add missing props to test file * simplify get feedback for multiple recording query * keep recommendationFeedback type same as recommendationFeedback enum don't mutate the previous state * add event.stopPagination to stop closing of dropdown when submitting feedback * use Icon + text for feedback * use regular font awsome icons in place of stroke * if feedback given render corresponding feedback solid * remove redundant log statements * don't use prevState value in currRecPage * remove componentDidUpdate * adjust alignement of feedback for mobile view * capitalize feedback text * don't show feedbacks options for user != currentUser * define mediaquery after regular padding * tests for feedback * don't overwrite afterRecommendationDisplay in tests * add comment to instruct eslint to ignore import issue * tests for db * check for html elements before and after updating feedback * test interdependency of button and dropdown * format tests - nitpicks * remove bad_recommendation feddback type * adjust spacing between emoticons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Database script to store recommendation feedback + Feedback API script to submit, delete, get recommendation feedback!