Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LB-755: Solve 500 in feedback api #1171

Merged
merged 3 commits into from Nov 30, 2020
Merged

LB-755: Solve 500 in feedback api #1171

merged 3 commits into from Nov 30, 2020

Conversation

shivam-kapila
Copy link
Collaborator

@shivam-kapila shivam-kapila commented Nov 7, 2020 •
edited

Problem

The /feedback/user/<user_name>/get-feedback-for-recordings returns 500 in prod if recordings arg is not pased

Solution

Raise 400 in such cases.

vansika
vansika approved these changes Nov 9, 2020
View reviewed changes
Copy link
Member

@vansika vansika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look fine but ig we should wait till tomorrow, you might want/need to add/delete stuff after the scheduled meeting on feedback.

@shivam-kapila
Copy link
Collaborator Author

@mayhem since the error is still in prod, I think we might want to deploy this fix. Please take a look.

@mayhem mayhem merged commit 49ee7ff into metabrainz:master Nov 30, 2020
@mayhem
Copy link
Member

mayhem commented Nov 30, 2020

Given that this 500 only occurs when the user uses the API wrong, it doesn't really warrant a separate release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vansika vansika vansika approved these changes

@mayhem mayhem Awaiting requested review from mayhem

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@shivam-kapila @mayhem @vansika