LB-579: Improve pagination buttons on "Recent Listens" and "User Artists" page #1211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
3 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
shivam-kapila
suggested changes
Dec 27, 2020
There was a problem hiding this comment.
Thanks for updating the snapshots. This looks okay now but I'd wait for the test results. @alastair can you please whitelist them.
|
@brainzbot add to whitelist |
|
Are these failed tests relevant here ? Do i need to make some changes? @alastair |
MonkeyDo
approved these changes
Jan 11, 2021
There was a problem hiding this comment.
Thanks for the PR @kshitijk83 !
This is a good improvement, it's been bothering me for a while :)
The failing tests are unrelated to the changes in the PR, so I'll go ahead and merge it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
Changed classname from "hidden" to "disabled"