Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broadcast playlist edits in real time using websockets #1212

Merged
merged 13 commits into from
Feb 10, 2021
Merged

Broadcast playlist edits in real time using websockets #1212

merged 13 commits into from
Feb 10, 2021

Commits on Jan 13, 2021

  1. Add websockets server to handle playlist changes

    @amCap1712
    amCap1712 committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    6c02a5a View commit details
    Browse the repository at this point in the history

  2. Add client side handling for playlist changes

    @amCap1712
    amCap1712 committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    0a4c198 View commit details
    Browse the repository at this point in the history

  3. Use separate config for playlist websockets server

    @amCap1712
    amCap1712 committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    14d689d View commit details
    Browse the repository at this point in the history

  4. Fix pep8speaks issues

    @amCap1712
    amCap1712 committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    c8b4717 View commit details
    Browse the repository at this point in the history

  5. Fix issues from code review

    @amCap1712
    amCap1712 committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    059f022 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2021

  1. Merge branch 'master' into pr/1212

    @MonkeyDo
    MonkeyDo committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    806686e View commit details
    Browse the repository at this point in the history

  2. Playlist: call emitPlaylistChanged only after setting state 

    This concerns the websocket playlist update mechanism.
We make sure we have set the state locally (after successful API calls) before calling emitPlaylistChanged as a callback, since it relies on that updated state.
    @MonkeyDo
    MonkeyDo committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    85c3fd8 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2021

  1. Merge branch 'master' into pr/1212

    @MonkeyDo
    MonkeyDo committed Jan 30, 2021
    Configuration menu
    Copy the full SHA
    6b7a0ee View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2021

  1. Add PLAYLIST_WEBSOCKETS_URL to config consul template

    @MonkeyDo
    MonkeyDo committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    4e53a03 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2021

  1. Merge follow server into websockets

    @amCap1712
    amCap1712 committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    ae8722d View commit details
    Browse the repository at this point in the history

  2. Change run_follow_server -> run_websockets in prod services

    @MonkeyDo
    MonkeyDo committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    1aff776 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into pr/1212

    @MonkeyDo
    MonkeyDo committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    040ac46 View commit details
    Browse the repository at this point in the history

  4. Remove PLAYLIST_WEBSOCKETS_URL from config 

    We use a single WEBSOCKETS_SERVER_URL now
    @MonkeyDo
    MonkeyDo committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    6746591 View commit details
    Browse the repository at this point in the history