Mock call to fetch_playlist_recording_metadata when getting playlists #1231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The only remaining failing integration tests are due to sporadic issues that we're still trying to track down. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Due to configuration issues, we currently can't connect to external hosts from tests in jenkins (LB-782).
The playlist get method makes a call to labs.api.listenbrainz.org to get metadata for the playlist given its mbids.
Because this is a unit test, we don't really want the result of this lookup to be determined by an external service anyway, so we should disable it when running tests.
Solution
mock the external api calls