LB-778: Don't clear add-to-playlist search input on blur #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it possible to add tests for this behaviour? |
I'll give it a go |
|
@brainzbot retest this please my dear |
MonkeyDo
force-pushed
the
add-to-playlist-search-input
branch
from
0daa46d
to
b73f76b
Compare
The solution is: cache everything! Cache the search query and prevent it from being cleared, and cache the ACRM results for that query too. Also don't close the results on select so that users can add multiple songs easily.
Fix a quirk with fontawesome hash ids that make the snapshots different each time.
To solve issue with snapshots and date string formatted with toLocaleString.
Using the previous commit's TZ change
MonkeyDo
force-pushed
the
add-to-playlist-search-input
branch
from
b73f76b
to
f14ee46
Compare
|
The Playlist component didn't have any tests. I added a standard "page loads OK" test with snapshot comparison and a test for the search input behavior that this PR changes. In the meantime, JS tests are passing (I know it looks like they're not, but that's because we're working on the Jenkins config). |
|
@brainzbot retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As [LB-778] mentions, currently in the playlist page when a user loses focus of the add-a-track search input, whatever query they had typed gets cleared.
The reason is that we're using the React-Select library with a bit of an edge use case and the default behavior is to allow searching within the options in the dropdown, rather than fetch API results.
The solution is to cache everything in the state and take manual control of the React-Select component.
Cache the search query and prevent it from being cleared, and cache the search results for that query too.
We also prevent the dropdown from closing when a user selects a result, so that they can easily add multiple songs from those same results.