Dump user feedback #1347
Merged
Dump user feedback #1347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nz-server into dump-user-feedback
…to dump-user-feedback
|
Hello @mayhem! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2021-04-12 17:00:21 UTC |
|
@brainzbot test again please |
|
Thinking out loud, would the recording_recommendation events in the user_timeline_event table be useful wherever this dump is gonna be used? |
|
Eventually yes. But realistically we're not there yet -- but with this in mind I created the spark FTP dir so that we can create more "out of replication sequence" dumps timed to be fresh for spark ingestion. |
amCap1712
reviewed
Mar 24, 2021
alastair
reviewed
Apr 12, 2021
…nz-server into dump-user-feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spark cluster needs to get period user and recommendation feedback data and this PR adds the functionality to dump a feedback dump and the rsync it to the FTP server. I anticipate that we'll add more spark data dumps in the future, so its good to have separate FTP dir for it.
Also in this PR is the change to keep 30 incremental feedback items. This gives users a complete month to catch up on incremental dumps -- 6 dumps was not enough for this.