Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 'notification' events on timeline UI #1359

Merged
merged 5 commits into from
Mar 30, 2021

Conversation

MonkeyDo
Copy link
Contributor

Hand in hand with PR #1342 , which adds an endpoint to add notification events for a user, this PR adds support for displaying the notification events (with a bell icon) and sanitizing and displaying the html message.

Copy link
Member

@amCap1712 amCap1712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. I tested locally and it works great! However, there was an oversight in my earlier PR, hence we also need to merge #1360 to get this to work.

@MonkeyDo
Copy link
Contributor Author

I realized I forgot to choose a color for notifications (under the icon). Let me add that.

@amCap1712 amCap1712 merged commit 5fd56a5 into master Mar 30, 2021
@amCap1712 amCap1712 deleted the monkey-notification-timeline-event-ui branch March 30, 2021 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants