Don't add GIT_COMMIT_SHA build to the label at the beginning of the build #1424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MonkeyDo
approved these changes
May 5, 2021
|
I set the vcs hash to empty at the beginning to override the base image version, and also added an additional ARG command necessary for setting the version in the based-on-image label |
…uild This causes all build to invalidate the entire cache as the GIT_COMMIT_SHA changes every time that we make a new image. Add it at the end after all other items have changed Also fix a bug around consuming ARGs that have a default value in LABELS. Now the org.metabrainz.based-on-image label correctly contains the version of the base image
alastair
force-pushed
the
add-git-hash-label-last
branch
from
99d5e57
to
fa4b9a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This causes all build to invalidate the entire cache as the
GIT_COMMIT_SHA changes every time that we make a new image.
Solution
Add the version label at the end after all other items have changed
Action