LB-984: Reject listens with a date before October 2002 #1693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had set this to 2005 earlier but later found in history that this used to be October 2002 instead and adjusting the date.
mayhem
approved these changes
Nov 3, 2021
alastair
reviewed
Nov 9, 2021
There was a problem hiding this comment.
Just a few small comments about grammar, otherwise good.
I left another comment here about lowest timestamps in the dumps, perhaps we can fix that here too: #1678 (comment)
Co-authored-by: Alastair Porter <alastair@metabrainz.org>
|
@alastair Thanks for the documentation improvement. Committed. |
alastair
approved these changes
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1679, we set this to 2005 but then later discovered that in an earlier version of the codebase it was October 2002. So changing to that and documenting. The comment about exception handling is dealt in a separate PR.