Add an option for creating fake users to api #170
Conversation
| @@ -140,7 +142,10 @@ def _validate_auth_header(): | |||
|
|
|||
| user = db.user.get_by_token(auth_token) | |||
| if user is None: | |||
| user = db.user.create_user_with_token(auth_token) | |||
| if CREATE_FAKE_USERS_FOR_STRESS_TESTING: | |||
There was a problem hiding this comment.
I know this has been merged, but is there a way that this can be integrated without having a create operation in a verify method?
Is it possible to make the stress-test tool send 2 requests (1 POST to create an account [under a similar guard as this one], and then the POST to save data)?
Is this setting used when DEBUG is set to False? If no, we could have a guard to make sure that CREATE_FAKE_USERS_FOR_STRESS_TESTING && !DEBUG is never true
There was a problem hiding this comment.
Hmm, I see your point. This is going to be used very rarely, in fact I plan to use it only one more time before our beta. Then this code can go away... But I think adding the guard is a pretty good idea.
There was a problem hiding this comment.
If you pinky swear that we're going to delete this code very soon, I'll let it slide, but a DEBUG guard would make me much less anxious
There was a problem hiding this comment.
https://tickets.metabrainz.org/browse/LB-161 -- I don't do NDAs or pinky swears. :D
As we talked about it here: https://chatlogs.metabrainz.org/brainzbot/metabrainz/2017-04-19/?msg=3888764&page=4