Allow tracknumber to be str in pydantic model #1875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amCap1712
changed the title
mayhem
approved these changes
Feb 21, 2022
There are a bunch of pydantic errors in sentry due to tracknumber being str but the model requiring it to be an integer. We don't validate tracknumber (see api_compat) to be an integer during submission so try to enforce it here is futile. And we don't use the tracknumber field anywhere anyway.
amCap1712
force-pushed
the
fix-tracknum
branch
from
af4b33c
to
e30b331
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a bunch of pydantic errors in sentry due to tracknumber being str but the model requiring it to be an integer. We don't validate tracknumber (see api_compat) to be an integer during submission so try to enforce it here is futile. And we don't use the tracknumber field anywhere anyway.