Add useful messages and call to actions for empty states on listens page #2039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move UserSocialNetwork modals to individual cards. - Conditionally show helpful messages on all modals if their state is empty. - Adjust and add appropriate styles.
Explicitly tell new users what the card shows instead of just showing them - "You have not listened to any songs so far" It didin't tell new users what'd they see had they listened to any song. The message - "Your listens count" followed by "You haven't listened to any songs." will subtly tell them what to expect in that place.
- Suggest user to import their listening history and connect to music services. - Replace "No listens yet" with a simple Vinyl illustration for empty state.
MonkeyDo
reviewed
Jun 27, 2022
listenbrainz/webserver/static/js/src/follow/FollowerFollowingModal.tsx
Outdated
Show resolved
Hide resolved
listenbrainz/webserver/static/js/src/follow/FollowerFollowingModal.tsx
Outdated
Show resolved
Hide resolved
listenbrainz/webserver/static/js/src/follow/FollowerFollowingModal.tsx
Outdated
Show resolved
Hide resolved
listenbrainz/webserver/static/js/src/follow/SimilarUsersModal.tsx
Outdated
Show resolved
Hide resolved
listenbrainz/webserver/static/js/src/follow/SimilarUsersModal.tsx
Outdated
Show resolved
Hide resolved
listenbrainz/webserver/static/js/src/listens/ListenCountCard.tsx
Outdated
Show resolved
Hide resolved
MonkeyDo
reviewed
Jun 28, 2022
Get rid of nested ternary operators.
- Replace hard-to-recognise Record Vinyl icon with a simple CD icon. - Remove "You haven't listened to any songs yet" subtitle because we have the exact same message in ListenCountCard component. - Remove unused css properties.
- This will unbreak the codebase.
|
After updates -
|
MonkeyDo
reviewed
Jul 4, 2022
listenbrainz/webserver/static/js/src/follow/SimilarUsersModal.tsx
Outdated
Show resolved
Hide resolved
MonkeyDo
reviewed
Jul 4, 2022
listenbrainz/webserver/static/js/src/follow/SimilarUsersModal.tsx
Outdated
Show resolved
Hide resolved
Based on this discussion: https://github.com/metabrainz/listenbrainz-server/pull/2039/files/1bdb39ed3fbbd6fd53302e2d5b047a046363ba8c#r913007576 Co-authored-by: Monkey Do <MonkeyDo@users.noreply.github.com>
|
I'll re run tests, update snapshots and resolve the merge conflict in some time. |
|
Just a heads up that with the last commit there is duplicated code: |
Leftovers from last commit
This causes test suite to fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A newly signed up user usually needs to connect to their Spotify to track their listens and import any existing listens from last.fm.
The user will also most probably navigate to "Home" after signing up. They may or may not have read or the "Get started..." paragraph on the main page of LB.
In such cases, have something for the user to do when they are on the Listens page and have no idea where to go from there.
The current listens page has no call to action links anywhere except in the profile button drop-down, which is hidden away from the interface.
Screenshots
Current Listens Page
Changes after this PR
Listenssection changes -ListenCountCardchanges -Explicitly tell new users what the card shows instead of just showing them -
It didin't tell new users what'd they see had they listened to any song.
The message -
...will subtly tell them what to expect in that place.
UserSocialNetworkchanges -