Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do not merge] Speed up LB tests #2094

Closed
wants to merge 180 commits into from
Closed

[Do not merge] Speed up LB tests #2094

wants to merge 180 commits into from

Conversation

amCap1712
Copy link
Member

This is a catch all changes PR to benchmark speeding up LB tests. It touches lots of parts of the codebase, some with partial or no test coverage. As such its not possible to review it well, the intent is to keep this PR as a record of all the changes that need to be made and open smaller PRs and improve speed incrementally.

@pep8speaks
Copy link

Hello @amCap1712! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 43:20: W291 trailing whitespace
Line 73:54: W292 no newline at end of file

Line 49:131: E501 line too long (135 > 130 characters)

Line 133:49: W291 trailing whitespace

Line 106:29: E128 continuation line under-indented for visual indent

Line 435:45: W291 trailing whitespace
Line 439:33: W291 trailing whitespace

Line 66:15: W291 trailing whitespace

Line 20:1: W293 blank line contains whitespace
Line 621:1: W293 blank line contains whitespace

Line 18:37: E203 whitespace before ':'

@MonkeyDo
Copy link
Contributor

As an aside, I recently removed the action-docker-layer-caching steps in the BB repo github actions after seeing reports of improved speed, and indeed my builds are now a lot faster without the caching steps.
Maybe something to remove from LB too?

@amCap1712
Copy link
Member Author

Oh, I see. The caching does take a lot of time so makes sense to remove that if the actual build time is less. I'll do some quick tests and will remove if its slower. Thanks!

@amCap1712 amCap1712 mentioned this pull request Sep 6, 2022
@amCap1712 amCap1712 closed this Sep 13, 2022
@amCap1712 amCap1712 deleted the tests-speed-up branch April 8, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants