New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Do not merge] Speed up LB tests #2094
Conversation
because now() is always fixed for the duration of the transaction and this is problematic for tests (all statements in a test run in the same transaction).
Hello @amCap1712! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
As an aside, I recently removed the |
Oh, I see. The caching does take a lot of time so makes sense to remove that if the actual build time is less. I'll do some quick tests and will remove if its slower. Thanks! |
This is a catch all changes PR to benchmark speeding up LB tests. It touches lots of parts of the codebase, some with partial or no test coverage. As such its not possible to review it well, the intent is to keep this PR as a record of all the changes that need to be made and open smaller PRs and improve speed incrementally.