Remove "Charts" tab from user page #2378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to improve the reports tab so that we can remove the charts tab. The charts page stays for now because it allows users to navigate through all their top entities rather than just show the top 10, but it does not need a whole separate tab. Users find this charts tab confusing because it duplicates some of the info in the reports tab.
We have som issues with display with the listen count badge. Too many items in that listencard, so for now hide the feedback buttons. Plus some UI tweaks to improve the look of the page a bit
+ Make the "reports" tab active when on a charts page
Missing newAlert prop
Starting to use these components everywhere, and also need them to accept anchor tags. Refactored the Pill component and extracted the styles into a LESS file. Also applied the same styles for pills across the website
Finally surfacing the global stats page with a link on a page !
lots of 'em !
…stenbrainz-server into goodbye-charts-tab
|
Updated screenshot with the user and global pills in the sub-nav, to the right, and renamed "statistics" tab: Yes, I know, the top artists card is not the same height as the other ones. But it's not so easy to solve and required making each card a flex item, etc. |
mayhem
approved these changes
Mar 6, 2023
|
Just noticed that the tracks in the top tracks are not playable… something else to fix. |
|
We'll hotfix both at the same time. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following in the footsteps of #2344 and #2343 in preparation for the Grand Redesing, losing another not-so-useful tab
Users (and the team as well) have been reporting that the charts tab is confusing as it seems to duplicate some of the information from the "Reports" tab.
It's also a not-very-usable page whoe sole reasons for existing are: 1. pagination and 2. playable listen cards
This PR tackles 2. by making the top entities in the "Reports" tab playable.
We need to keep the charts page because we currently don't have a good solution for 1., but it can be a hidden page with no direct access other than the "View more…" buttons/links on the Reports tab:
Removed another tab:
In the process, I had to make a couple of CSS changes to improve our compact ListenCard
The Reports page before:
The Reports page after:
