LB-1177: Mobile navbar link broken for Year in Music #2443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MonkeyDo
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When no user is logged in, clicking the YIM 2021 navbar link on mobile directs the user to the broken link:
https://listenbrainz.org/user//year-in-music
Instead of:
https://listenbrainz.org/user//year-in-music
Related JIRA Ticket: LB-1177
Solution
The jinja template for the navbar needs to ascertain whether a user is logged in, and hide the year in the music link if not.
When a user is not logged in. Hiding the Year in Music
When a user is logged in. Showing the Year in Music
