Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LB-1280: Manual mbid mapping: Duplicate text/fill search field. #2565

Merged
merged 7 commits into from
Sep 15, 2023
Merged

LB-1280: Manual mbid mapping: Duplicate text/fill search field. #2565

merged 7 commits into from
Sep 15, 2023

Conversation

KasukabeDefenceForce
Copy link
Contributor

Problem

Often when matching listens to MBID's in LB, you're re-typing or copying and pasting the raw text, displayed tantalizingly out of reach a few px above the search field.

Solution

Added the functionality for a copy button that fills the search field.

Action

MonkeyDo
MonkeyDo requested changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR !
Some things to change, but it's nice to see this feature going :)

frontend/js/src/utils/SearchTrackOrMBID.tsx Outdated Show resolved Hide resolved
frontend/css/theme/bootstrap/mixins/buttons.less Outdated Show resolved Hide resolved
frontend/css/theme/bootstrap/mixins/buttons.less Outdated Show resolved Hide resolved
MonkeyDo
MonkeyDo requested changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this time it's my turn to have been a bit too hasty with my review :)

I ran the PR and tested it, and came up with a few more suggestions:

frontend/js/src/mbid-mapping/MBIDMappingModal.tsx Outdated Show resolved Hide resolved
frontend/js/src/mbid-mapping/MBIDMappingModal.tsx Outdated Show resolved Hide resolved
@MonkeyDo
Copy link
Contributor

Now it looks great, thanks ! :)

@MonkeyDo MonkeyDo merged commit 2c562e0 into metabrainz:master Sep 15, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MonkeyDo MonkeyDo MonkeyDo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@KasukabeDefenceForce @MonkeyDo