LB-1332: Display user top navigation on playlist page #2598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the playlist page does not show any navbar at the top of the page, a departure from our other pages that is confusing and doesn't look great.
As discussed in LB-1332 we decided to show the navbar associated with the playlist's owner, to facilitate useful navigation.
The rationale was: "I assume most of the time people will be navigating from that persons playlist page anyway, or from their YIM or similar, so I think this makes sense. Even if they're randomly linked from the internet it invites them to explore the playlist creator's other pages."
Before:
After:
P.S: ^ here I am not logged in